Why?
Code quality analysis helps you to make your code:
- less error-prone
- more sustainable
- more reliable
- more readable
- more welcoming to new contributors
It is also a mandatory step for projects willing to enter the PolarSys Maturity Assessment, as the analysis process relies on code metrics extracted by SonarQube.
How?
Code quality analysis mainly relies on a set of tools that look at your code and give you hints. The most famous tools are Findbugs, PMD, Checkstyle; but also code coverage tools such as JaCoCo. JDT itself provides very powerful quality checks, but there are not enabled by default. You should go to Error/Warnings in preferences and replace all "ignore" by "Warning". You can (and should) enable such tools in IDE.
Code quality can also be analyzed out of the IDE, running those tools and using their reports to find out the "hot spots" in your code.
About SonarQube
SonarQube (formerly known as Sonar) is an open-source product which is used to gather several metrics about code quality, put them all in a single dashboard, and provide some tips to help you making your code better, more sustainable, more reliable, less bugged.
SonarCloud.io is the "cloud"-version of SonarQube hosted by SonarSource.
If your project wants to use SonarCloud.io, please open a HelpDesk issue to request it. Please specify for which exact project this should be setup.
The webmaster/releng team will create the respective SonarCloud.io repository for your project and add a SONAR_TOKEN to your project's GitHub repo or the SONARCLOUD_TOKEN to your project's Jenkins instance.
Usage
If the project's source code is hosted on GitHub, the built-in GitHub integration can be used for some languages (see https://docs.sonarcloud.io/getting-started/github/). Otherwise the project must have a Jenkins instance or use GitHub actions (see https://github.com/SonarSource/sonarcloud-github-action).
See how to get a dedicated JIPP. You should first setup a normal build to make sure the project compiles correctly.
In Jenkins your build job needs to be modified as follows:
- Job config
- “Use secret text(s) or file(s)
- Add -> Secret text
- Select “SonarCloud token”
- Variable: SONARCLOUD_TOKEN
- Add -> Secret text
- “Use secret text(s) or file(s)
- "Prepare SonarQube Scanner environment" option needs to be enabled
- In Maven build step, Goals:
sonar.projectKeysonar.organization
Running mvn sonar:sonar in your Maven build will result in the following flow of actions:
- The Maven SonarQube plugin will locally analyze code and generate reports from many analyzers
- The Maven SonarQube plugin will push those reports to SonarCloud
Several Eclipse projects already have quality reports enabled. You can drill-down on code to see annotations on each class, or navigate through the different widgets on the dashboard to focus on specific issues.
Permissions
By default only Eclipse Webmaster can administrate the analysis projects on SonarCloud.io. If you need admin permissions on some analysis projects, please open a HelpDesk issue, specifying which analysis projects you want to administrate. The name of the analysis must be close enough to the project's name. If you are not the project lead, don't forget to ask for a +1.
Note
The initial documentation referenced Mickael Istria's blog entry at http://mickaelistria.wordpress.com/2012/10/08/sonar-at-eclipse-org/ . The information in it regarding the Eclipse process is outdated, but the article is still a good reading to understand how SonarQube works and what it can bring to you.